Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code to interrupt the execution #1361

Closed
wants to merge 26 commits into from
Closed

Conversation

mbakli
Copy link
Contributor

@mbakli mbakli commented Jun 5, 2020

Fixes #232 .

Changes proposed in this pull request:

  • Abort the execution in case of an interruption occurs (e.g. the query is being canceled). The interruption check function has been added before every call to the main boost functions such as dijkstra_shortest_paths, dijkstra_shortest_paths_no_init, etc.
  • Suppress the -Wconversion warning in src/trsp/trsp.c

@pgRouting/admins

@dkastl
Copy link
Member

dkastl commented Jun 30, 2020

@cvvergara , shouldn't a PR point to develop branch, or is this one a "special" case?

@cvvergara cvvergara added this to the Release 3.0.1 milestone Jul 3, 2020
@cvvergara
Copy link
Member

@dkastl This honors cancellation of execution on many functions. Thing that was pending for many years.
So we don't do back porting (aka add to 3.1 then back port to 3.0)

@mbakli
Copy link
Contributor Author

mbakli commented Jul 3, 2020

Changing this pull request to a two commit pull request.

@mbakli mbakli closed this Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Honor client cancel requests in C /C++ code
3 participants