Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New function pgr_trsp_withPoints (Closing #2245) #2246

Merged

Conversation

cvvergara
Copy link
Member

Fixes #2245

Changes proposed in this pull request:

  • pgtap
    new tests for new signature(s)
  • sql
    • deprecated old signature
    • created 5 new signatures:
      • one to one, one to many, many to one, many to many and combinations signatures
  • c/c++
    • added/adjusted the necessary code
  • doc
  • updated the documentation queries used in the documentation
  • added the documentation on pgr_trsp_withPoints.rst
  • added release notes and NEWS about the changes

https://github.com/orgs/pgRouting/teams/admins

@cvvergara cvvergara added this to the Release 3.4.0 milestone Feb 4, 2022
@cvvergara cvvergara self-assigned this Feb 4, 2022
@cvvergara cvvergara changed the title New function pgr trspwith points (Closing #2245) New function pgr_trsp_withPoints (Closing #2245) Feb 4, 2022
Copy link
Member

@krashish8 krashish8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One docquery test is failing, related to trsp

@cvvergara
Copy link
Member Author

@krashish8 Indeed the problem as first glance is how postgres outputs the context on version 13 is what I get and the test is done with postgres 14. but that is the first glance. I will see further

< CONTEXT:  PL/pgSQL function pgr_trsp(text,integer,double precision,integer,double precision,boolean,boolean,text) line 113 at RETURN QUERY
---
> CONTEXT:  SQL statement "SELECT * FROM _pgr_trsp(new_sql, source_eid, source_pos, target_eid, target_pos, directed, has_reverse_cost, turn_restrict_sql)"
> PL/pgSQL function pgr_trsp(text,integer,double precision,integer,double precision,boolean,boolean,text) line 113 at RETURN QUERY',

@krashish8
Copy link
Member

Yes, maybe we can remove the CONTEXT in the result, by setting the verbosity level, so that the tests are compatible with all the versions.

@cvvergara
Copy link
Member Author

@krashish8 fixed, and btw I found a syntax error and fixed it can you review?

@cvvergara
Copy link
Member Author

Lets ignore the codacy error

@cvvergara
Copy link
Member Author

its because the backslash I had to use to set the verbosity

@cvvergara cvvergara merged commit c83e439 into pgRouting:develop Feb 6, 2022
@cvvergara cvvergara deleted the new-function-pgr_trspwithPoints branch February 6, 2022 15:44
@cvvergara
Copy link
Member Author

Updated dev-4.0 with these changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants