-
Notifications
You must be signed in to change notification settings - Fork 9
Conversation
Add Automatic-Module-Name entry to the MANIFEST.MF Value is `org.postgresql.jdbc` pgjdbc/pgjdbc#1031
This PR adds @AlexElin's changes of pgjdbc/pgjdbc#1059 to pgjdbc-parent-pom as suggested by @vlsi . |
Is there any way to test this ? |
@davecramer Yes, I tested this by adjusting the parent version of https://github.com/pgjdbc/pgjdbc/blob/master/pgjdbc/pom.xml#L6 to
|
@davecramer Can this be merged? |
So I've just tested this and from what I can tell we have to use a JDK > 1.8 to build it to make this happen, it's somewhat easier to add it to pgjdbc/pom.xml <plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
<configuration>
<archive>
<manifestEntries>
<Automatic-Module-Name>org.postgresql.jdbc</Automatic-Module-Name>
</manifestEntries>
</archive>
</configuration>
</plugin> |
@davecramer I'm not sure I understand why you'd need a JDK > 1.8 to build it. The code snippet you shared will run on older JDKs. I must have misunderstood what you meant somehow :) |
@cowwoc When I tried this using jdk8 the Automatic-Module-Name was not in the manifest. When I switched to JDK10 it was. I'd love to be proven wrong. |
@davecramer This seems to work for me under JDK 8. I ran |
Seems to work fine in travis using maven as well. I have no idea what I did wrong. I prefer it in maven |
fixed in pgjdbc/pgjdbc#1538 |
Thank you! |
Add Automatic-Module-Name entry to the MANIFEST.MF
Value is
org.postgresql.jdbc
pgjdbc/pgjdbc#1031