Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Anonymous=false: Fix after sign up redirect path #2735

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

pglombardo
Copy link
Owner

@pglombardo pglombardo commented Nov 6, 2024

Description

Reported by a user via email who was using PWP__ALLOW_ANONYMOUS=false:

"after creating an account it doesnt show the pop up which tells 
me to verify my e-mail. It rather shows the same pop up which 
can be confusing for the end user.

This PR changes the after sign up path when account confirmation is required (pretty much always).

Now after sign up when PWP__ALLOW_ANONYMOUS=false, you get this:

Screenshot 2024-11-06 at 09 26 48

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've written tests (if applicable) for all new methods and classes that I created. (rake test)
  • I've added documentation as necessary so users can easily use and understand this feature/fix.

@pglombardo pglombardo changed the title Allow Anonymous: Fix after sign up redirect path Allow Anonymous=false: Fix after sign up redirect path Nov 6, 2024
@pglombardo pglombardo merged commit 744291a into master Nov 6, 2024
6 checks passed
@pglombardo pglombardo deleted the fix-emrin-nov6 branch November 6, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant