Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use types from the lighter-weight postgres-types #16

Merged
merged 1 commit into from
Apr 14, 2024

Conversation

shadaj
Copy link
Contributor

@shadaj shadaj commented Apr 14, 2024

The imports for postgres::types are just a re-export of tokio_postgres::types, so this reduces the number of transitive dependencies brought in with the postgres feature (in particular, eliminating the full feature on Tokio).

@ankane
Copy link
Member

ankane commented Apr 14, 2024

Hi @shadaj, thanks for the PR! Seems like it'd be better to use the postgres-types crate instead.

@shadaj shadaj changed the title Use types from the lighter-weight tokio-postgres Use types from the lighter-weight postgres-types Apr 14, 2024
@shadaj
Copy link
Contributor Author

shadaj commented Apr 14, 2024

@ankane ah good point! fixed!

@ankane ankane merged commit 221c36c into pgvector:master Apr 14, 2024
1 check passed
@ankane
Copy link
Member

ankane commented Apr 14, 2024

Awesome, thanks!

@shadaj shadaj deleted the types-tokio-postgres branch April 14, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants