Fix bug #947

phalcon · Jul 30, 2013 · c3166d9 · c3166d9
1 parent e1a9e5a
commit c3166d9
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 3 deletions.
diff --git a/ext/tag.c b/ext/tag.c
@@ -700,8 +700,10 @@ PHP_METHOD(Phalcon_Tag, _inputFieldChecked){
 
 		PHALCON_OBS_VAR(current_value);
 		phalcon_array_fetch_string(&current_value, params, SL("value"), PH_NOISY);
-		if (PHALCON_IS_EQUAL(current_value, value)) {
-			phalcon_array_update_string_string(&params, SL("checked"), SL("checked"), PH_SEPARATE);
+		if (Z_TYPE_P(value) != IS_NULL) {
+			if (PHALCON_IS_EQUAL(current_value, value)) {
+				phalcon_array_update_string_string(&params, SL("checked"), SL("checked"), PH_SEPARATE);
+			}
 		}
 	} else {
 		/** 

diff --git a/unit-tests/TagTest.php b/unit-tests/TagTest.php
@@ -71,4 +71,34 @@ public function testIssue744()
 			$this->assertTrue(true);
 		}
 	}
-}
+
+	public function testIssue947()
+        {
+		use Phalcon\Tag;
+		$di = new Phalcon\DI\FactoryDefault();
+		Tag::setDI($di);
+
+		$html = Tag::radioField(array(
+		    'test',
+		    'value' => 1,
+		    'checked' => 'checked'
+		));
+		$pos = strpos($html, 'checked="checked"');
+		$this->assertTrue($pos !== FALSE);
+
+		$html = Tag::radioField(array(
+		    'test',
+		    'value' => 0
+		));
+		$pos = strpos($html, 'checked="checked"');
+		$this->assertTrue($pos === FALSE);
+
+		Tag::setDefault("test", "0");
+		$html = Tag::radioField(array(
+		    'test',
+		    'value' => 0
+		));
+		$pos = strpos($html, 'checked="checked"');
+		$this->assertTrue($pos !== FALSE);
+        }
+}