Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: \Phalcon\Debug and russian language #1099

Closed
ovr opened this issue Aug 16, 2013 · 8 comments
Closed

Bug: \Phalcon\Debug and russian language #1099

ovr opened this issue Aug 16, 2013 · 8 comments

Comments

@ovr
Copy link
Contributor

ovr commented Aug 16, 2013

Hi, all!
When i use

(new  \Phalcon\Debug())->listen();

In output html No

<meta http-equiv="Content-Type" content="text/html; charset=utf-8"/>

And russian language is uncorrect :(
And how i can use it for all errors?
@ghost ghost mentioned this issue Aug 16, 2013
Merged
@dreamsxin
Copy link
Contributor

@sjinks You too fast, it left me with such a small problem that novice changing for the bette. :)

@ovr
Copy link
Contributor Author

ovr commented Aug 16, 2013

I checkout to branch 1.3.0 cherry-pic pick u commit recompile restart but no utf-8 meta tag.

zaets28rus@web-server:~/www/cphalcon/build$ git branch
  1.2.3
* 1.3.0
  master

zaets28rus@web-server:~/www/cphalcon/build$ git log -n 2
commit 8dc3ba6b0fae64a5706b8777c92a41a11fcde4dd
Author: Vladimir Kolesnikov <[email protected]>
Date:   Fri Aug 16 06:00:17 2013 +0300

    Fix #1099

commit d318426bb3ca6e6bfa76612e5b548f3ed9a23ce6
Author: phalcon <[email protected]>
Date:   Thu Aug 15 17:07:42 2013 -0500

    Unused variables [ci skip]

@dreamsxin
Copy link
Contributor

@zaets28rus Wait phalcon merger.

@ghost
Copy link

ghost commented Aug 16, 2013

@zaets28rus Could you please paste the HTML you see?

@ovr
Copy link
Contributor Author

ovr commented Aug 16, 2013

code for test

<?php
(new \Phalcon\Debug())->listen(true, true);
throw new \Exception('Превосходная работа, Владимир :)');

https://gist.github.com/zaets28rus/cbd713b4cb5687399aa9
maybe exstion compile to other path? and how i can check it?

@ghost
Copy link

ghost commented Aug 16, 2013

Works for me:

<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"/><title>Exception: Превосходная работа, Владимир :)</title><link href="//static.phalconphp.com/debug/1.2.0/jquery/jquery-ui.css" type="text/css" rel="stylesheet" /><link href="//static.phalconphp.com/debug/1.2.0/themes/default/style.css" type="text/css" rel="stylesheet" /></head>

@xboston
Copy link
Contributor

xboston commented Aug 16, 2013

and my
exception

phalcon pushed a commit that referenced this issue Aug 16, 2013
Merge pull request #1100 from sjinks/1099
78c1dbd 
Fix #1099
@phalcon
Copy link
Collaborator

phalcon commented Aug 17, 2013

This was implemented in the 1.3.0 branch

@phalcon phalcon closed this as completed Aug 17, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@xboston @dreamsxin @ovr