Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFR] Implement: Phalcon\Logger\Adapter::isTransaction() #1238

Closed
temuri416 opened this issue Sep 16, 2013 · 3 comments
Closed

[NFR] Implement: Phalcon\Logger\Adapter::isTransaction() #1238

temuri416 opened this issue Sep 16, 2013 · 3 comments

Comments

@temuri416
Copy link
Contributor

We need a way of knowing whether Logger has an active transaction that can be committed/rolled back.

Currently, there is no getter for that attribute.

Implement:

Phalcon\Logger\Adapter::isTransaction()

Return boolean.
@temuri416 temuri416 mentioned this issue Sep 25, 2013
Closed
@temuri416
Copy link
Contributor Author

@dreamsxin

What is the status of the fix? Will it be committed any time soon? Thanks!

@dreamsxin dreamsxin mentioned this issue Sep 26, 2013
Merged
@temuri416
Copy link
Contributor Author

@dreamsxin

Pull request seems to be stuck... Is there a problem? I really need this one merged.

Thanks!

phalcon pushed a commit that referenced this issue Sep 30, 2013
Merge pull request #1295 from dreamsxin/1238
38ed6f7 
Fix nfr #1238
@phalcon
Copy link
Collaborator

phalcon commented Oct 2, 2013

This is implemented in 1.3.0

@phalcon phalcon closed this as completed Oct 2, 2013
@temuri416 temuri416 mentioned this issue Aug 14, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@temuri416