[BUG] Model\Query throws fatal error

[quasipickle]

Hi,

When I run this code from a model:

$Query = new \Phalcon\Mvc\Model\Query($phql);

I get this output:

Fatal error: Phalcon\Mvc\Model\Query::_prepareSelect(): Call to method load() on a non object in /var/www/htdocs/app/models/Item.php on line 109

I realize this is because I'm not sending my DI container as the second argument. However, I feel this should trigger an exception.

It would seem the second argument is optional, due to the fact PHP isn't throwing an error saying an argument is missing. However I'm guessing code later in the method NEEDS the DI to be set. This should cause an exception to be thrown.

[ghost]

Can this one be closed now?

[zyxep]

Hi, i am currently running stable 1.2.4 and getting this error of course.
why is it merged into 1.3.0 and not 1.2.5 too?

would it be safe to upgrade to 1.3.0 ?

[ghost]

@zyxep Those errors are not critical (ie they do not lead to a crash and only happen when the user is misusing the class) and the code in 1.2.x and 1.3.0 has diverged much -- the patch won't apply cleanly, this is why I did not backport the fix into 1.2.5.

As for upgrade -- I do use 1.3.0 in the production and it works like a charm, but your mileage may vary and I would suggest to test 1.3.0 on the dev server first.

[zyxep]

then someone should tell me how to use the code then.
The documentation http://docs.phalconphp.com/en/latest/reference/phql.html#creating-phql-queries does say

<?php

// Instantiate the Query
$query = new Phalcon\Mvc\Model\Query("SELECT * FROM Cars", $di);

// Execute the query returning a result if any
$cars = $query->execute();

i use it this way

<?php
use Phalcon\Mvc\Model,
    Phalcon\Mvc\Model\Query;

class Gallery extends Model
{
    public function get_pictures($options = array())
    {
        $sql  = "SELECT p.id, p.filename ";
        $sql .= "FROM pictures p WHERE ";
        $sql .= "p.status = 'active' ";

         $query = new Query($sql);
        return $query->execute();
    }
}

I doesn't see any different from the documentation to my code.
and if there isn't a updated documentation for version 1.3.0 then i think i should use 1.2.4 because i am really new at phalcon :)

[quasipickle]

This is a closed bug report - not the place to ask for help with code. Use the forum for that.

[phalcon]

Try this:

<?php

use Phalcon\Mvc\Model,
    Phalcon\Mvc\Model\Query;

class Gallery extends Model
{
    public function get_pictures($options = array())
    {
        $sql  = "SELECT p.id, p.filename ";
        $sql .= "FROM pictures p WHERE ";
        $sql .= "p.status = 'active'";
        $query = new Query($sql, $this->getDI());
        return $query->execute();
    }
}

or:

<?php

use Phalcon\Mvc\Model,
    Phalcon\Mvc\Model\Query;

class Gallery extends Model
{
    public function get_pictures($options = array())
    {
        return Pictures::find(array(
            'columns' => 'id, filename',
            'conditions' => 'status = "active"'
        ))
    }
}

[zyxep]

Thanks it helped, i will not disturb you anymore :)

[bhoopal10]

how to join two table by using common id? sorry my bad English :(

'question_id', 'questionModuleID' => 'questionModuleID', 'questionText' => 'questionText', 'questionOptions' => 'questionOptions', 'questionMarks' => 'questionMarks' ); } public function initialize() { $this->hasMany("questionModuleID","Module","module_id"); } ```