Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minify file size is 0. #821

Closed
dreamsxin opened this issue Jul 10, 2013 · 6 comments
Closed

minify file size is 0. #821

dreamsxin opened this issue Jul 10, 2013 · 6 comments

Comments

@dreamsxin
Copy link
Contributor

$this->assets->collection('jsHeader')

    ->addJs('js/jquery.js')
    ->addJs('js/bootstrap.js')
    ->addJs('assets/js/holder.js')

    ->addFilter(new Phalcon\Assets\Filters\Jsmin())

    ->join(true)

    ->setTargetPath('js/final.js')
    ->setTargetUri('js/final.js');

In view file:

<?php $this->assets->outputJs('jsHeader') ?>
@ghost
Copy link

ghost commented Jul 10, 2013

Same as #811?

@bluntik
Copy link

bluntik commented Jul 10, 2013

I have same problem

@ghost
Copy link

ghost commented Jul 10, 2013

Happens only with join(true).

@phalcon
Copy link
Collaborator

phalcon commented Jul 10, 2013

I'm working on a fix...

@philippgerard
Copy link

Any ETA for this? :)

@dreamsxin
Copy link
Contributor Author

Find the question.
file:manager.c
line:628

        /** 
         * If the collection must not be joined we must print a HTML for each one
         */
        if (Z_TYPE_P(filters) == IS_ARRAY) { 
            if (!zend_is_true(join)) {

change:

        /** 
         * If the collection must not be joined we must print a HTML for each one
         */
        if (Z_TYPE_P(filters) == IS_ARRAY) { 
            if (zend_is_true(join)) {

niden added a commit that referenced this issue Jul 23, 2013
Fix bug #821 and #811 Minifier: No output at all
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants