Fixed virtual foreign key check

[ghost]

Hi,

I am reopening PR #11975 for 3.0.x branch.

[ghost]

@sergeyklay I have returned the default value for validateWithNulls variable, but it is set also in the for loop now.

Wouldn't it be more friendly to set it only once in the for loop? It's not used anywhere the outside of the for loop I guess, so assigning the value twice might not be that readable.

[sergeyklay]

Your PR does not make sense right now because the validateWithNulls has been set previously, before the loop

[ghost]

I do not understand. That was originally the problem, when it was set before the loop.

Because when you have a model with more than one virtual foreign key, first foreign key check leaves the validateWithNulls set and might be incorrect for the next for loop iteration.

That is why I removed the default value and put the assignment inside the for loop.

[Jurigag]

He just means if relation is null then if there is enabled notNullValidations it should pass.

[sergeyklay]

Okay, could you please provide a small test which cover this case?

[ghost]

I'll definitely give it a try.

[sergeyklay]

@crnix I have investigated the code more details. Yes. You're right. It be more correct to set it the for loop. But in any case your PR need to be tested.

[sergeyklay]

Also could you please find the issue or open new one with script to reproduce the problem and refer this PR to the issue

[ghost]

OK, so here is the issue with steps to reproduce this #12071

[ghost]

Could you explain to me please or refer me to some description what is the difference between tests and unit-tests folders?

Also, where can I define the database tables for the test? Is it OK to add them to tests/_data/schemas/mysql/mysql.dump.sql?

[sergeyklay]

Could you explain to me please or refer me to some description what is the difference between tests and unit-tests folders?

Use always the tests folder. In the future all tests will be located in the the tests folder.

Also, where can I define the database tables for the test? Is it OK to add them to tests/_data/schemas/mysql/mysql.dump.sql?

Yes. But don't forget to amend tables https://github.com/phalcon/cphalcon/blob/3.0.x/tests/unit/Db/Adapter/Pdo/MysqlTest.php

[sergeyklay]

Refer to the issue please

[sergeyklay]

@crnix Add new tables here https://github.com/phalcon/cphalcon/blob/3.0.x/tests/unit/Db/Adapter/Pdo/MysqlTest.php#L58-L81

[sergeyklay]

Thanks!

[ghost]

You are welcome