3.1.x model code fix #12674
Merged
3.1.x model code fix #12674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jurigag
force-pushed
the
3.1.x-model-code-fix
branch
2 times, most recently
from
037b33b
to
25a504e
Compare
Jurigag
force-pushed
the
3.1.x-model-code-fix
branch
10 times, most recently
from
ca7255b
to
3b282c4
Compare
Jurigag
commented
Mar 3, 2017
| @@ -1505,7 +1505,9 @@ abstract class Model implements EntityInterface, ModelInterface, ResultInterface | |||
| new Message( | |||
| message->getMessage(), | |||
| message->getField(), | |||
| message->getType() | |||
| message->getType(), | |||
| null, | |||
There was a problem hiding this comment.
Im not really sure about this null, it should be this here anyway, but this will break tests(not sure about apps).
|
@Jurigag Could you please rebase |
Jurigag
force-pushed
the
3.1.x-model-code-fix
branch
from
3b282c4
to
9a55c8d
Compare
|
@sergeyklay rebased |
sergeyklay
approved these changes
Mar 8, 2017
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following (please check boxes):
Small description of change: model validate wasn't setting code in model message got from validation message, now it does.
Also i changed test structure, now models with validation are moved to seperated namespace.
Thanks