Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix snapshot setting when create/update operation made #12678

Merged
merged 1 commit into from
Mar 4, 2017

Conversation

Jurigag
Copy link
Contributor

@Jurigag Jurigag commented Mar 3, 2017

Hello!

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines?
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR.

Small description of change: This is adding setting snapshot to correct one when creating/updating model operation were succesfully made.

Thanks

@Jurigag Jurigag force-pushed the 3.1.x-model-snapshot-fix branch 8 times, most recently from 3dc7f11 to bd12eb6 Compare March 3, 2017 18:39
@Jurigag
Copy link
Contributor Author

Jurigag commented Mar 3, 2017

Old tests were written in wrong way, for bugged feature, making this change breaking them(getChangedFields were made in wrong place). I will fix them in this PR too.

@sergeyklay sergeyklay merged commit 451977c into phalcon:3.1.x Mar 4, 2017
@sergeyklay
Copy link
Contributor

Thank you

@Jurigag Jurigag deleted the 3.1.x-model-snapshot-fix branch March 9, 2017 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants