Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phalcon\Security::computeHmac() plus many bug fixes #1347

Merged
merged 16 commits into from Oct 8, 2013
Merged

Phalcon\Security::computeHmac() plus many bug fixes #1347

merged 16 commits into from Oct 8, 2013

Conversation

ghost
Copy link

@ghost ghost commented Oct 8, 2013

The initial idea of this PR was to introduce Phalcon\Security\computeHmac() function which computes HMAC of the given message — it can be used to verify both the data integrity and the authentication of a message. One of its possible applications is to verify that the cookies were not tampered with.

Bug fixes included into this PR:

To properly fix #1340 (and similar bugs in the rest of the code) I have made these changes:

  • PHALCON_SEPARATE_PARAM() now always separates its parameter — regardless of its refcount;
  • introduced phalcon_fetch_parameters_ex() function and fetch_params_ex() macro — these ones return zval** instead of zval*. However, this allows to use SEPARATE_ZVAL() on the returned arguments without worrying about memory leaks;
  • introduced convenience macros for type conversion — PHALCON_ENSURE_IS_xxx(). These ones take zval** as their argument, separate it if it is not a reference and perform type conversion. These macros are friendly to memory frames; they can work with method arguments but only if the arguments were fetched with fetch_params_ex().

phalcon pushed a commit that referenced this pull request Oct 8, 2013
Phalcon\Security::computeHmac() plus many bug fixes
@phalcon phalcon merged commit f5bedff into phalcon:1.3.0 Oct 8, 2013
@ghost ghost deleted the security branch October 9, 2013 07:55
@ghost ghost mentioned this pull request Oct 9, 2013
phalcon pushed a commit that referenced this pull request Oct 9, 2013
[1.2.4] Backport bug fixes from #1347
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants