Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T15556 volt compiler block #15557

Merged
merged 6 commits into from
Jun 28, 2021
Merged

T15556 volt compiler block #15557

merged 6 commits into from
Jun 28, 2021

Conversation

niden
Copy link
Member

@niden niden commented Jun 26, 2021

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Fixed Phalcon\Mvc\View\Engine\Volt\Compiler for a use case when a block will return null vs an array for statementList in PHP 8 (type error)

Thanks

@niden niden added 5.0 The issues we want to solve in the 5.0 release bug A bug report status: high High labels Jun 26, 2021
@niden niden changed the base branch from master to 5.0.x June 26, 2021 17:36
@niden niden requested a review from Jeckerson June 26, 2021 17:59
@niden niden self-assigned this Jun 26, 2021
@niden niden merged commit 3d7feb4 into phalcon:5.0.x Jun 28, 2021
@niden niden deleted the T15556-volt-compiler-block branch June 28, 2021 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: high High
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants