Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T15119 db getinternalhandler #15735

Merged
merged 3 commits into from
Oct 24, 2021
Merged

T15119 db getinternalhandler #15735

merged 3 commits into from
Oct 24, 2021

Conversation

niden
Copy link
Member

@niden niden commented Oct 24, 2021

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Changed Phalcon\Db\Adapter\AdapterInterface::getInternalHandler() and Phalcon\Db\Adapter\Pdo\AbstractPdo::getInternalHandler() to return var instead of \PDO for custom adapters with different engines

Thanks

@niden niden changed the base branch from master to 5.0.x October 24, 2021 11:12
@niden niden requested a review from Jeckerson October 24, 2021 11:12
@niden niden self-assigned this Oct 24, 2021
@niden niden added 5.0 The issues we want to solve in the 5.0 release breaks bc Functionality that breaks Backwards Compatibility bug A bug report status: medium Medium labels Oct 24, 2021
@niden niden linked an issue Oct 24, 2021 that may be closed by this pull request
[BUG]: \Phalcon\Db\Adapter\AdapterInterface::getInternalHandler expects \PDO #15119
Closed
Jeckerson
Jeckerson previously approved these changes Oct 24, 2021
View reviewed changes
@niden niden merged commit b00cf9a into phalcon:5.0.x Oct 24, 2021
@niden niden deleted the T15119-db-getinternalhandler branch October 24, 2021 14:53
@niden niden mentioned this pull request Oct 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeckerson Jeckerson Jeckerson left review comments

Assignees

@niden niden

Labels
5.0 The issues we want to solve in the 5.0 release breaks bc Functionality that breaks Backwards Compatibility bug A bug report status: medium Medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: \Phalcon\Db\Adapter\AdapterInterface::getInternalHandler expects \PDO
2 participants
@niden @Jeckerson