Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T15637 sql variables array #15750

Merged
merged 3 commits into from
Nov 1, 2021
Merged

T15637 sql variables array #15750

merged 3 commits into from
Nov 1, 2021

Conversation

niden
Copy link
Member

@niden niden commented Oct 31, 2021

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Renamed Phalcon\Db\Adapter\AbstractAdapter::getSqlVariables() to Phalcon\Db\Adapter\AbstractAdapter::getSQLVariables() to align with the rest of the getSQL* methods

Fixed Phalcon\Db\Adapter\AbstractAdapter::getSQLVariables() to return an empty array when initialized

Thanks

@niden niden requested a review from Jeckerson October 31, 2021 23:41
@niden niden self-assigned this Oct 31, 2021
@niden niden changed the base branch from master to 5.0.x October 31, 2021 23:41
@niden niden added 5.0 The issues we want to solve in the 5.0 release breaks bc Functionality that breaks Backwards Compatibility bug A bug report status: medium Medium labels Oct 31, 2021
@niden niden linked an issue Oct 31, 2021 that may be closed by this pull request
[NFR]: Return value of Phalcon\Db\Adapter\AbstractAdapter::getSqlVariables() must be of the type array, null returned" #15637
Closed
Jeckerson
Jeckerson previously approved these changes Nov 1, 2021
View reviewed changes
@niden niden merged commit d377e6e into phalcon:5.0.x Nov 1, 2021
@niden niden deleted the T15637-sql-variables-array branch November 1, 2021 13:06
@niden niden mentioned this pull request Nov 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeckerson Jeckerson Jeckerson left review comments

Assignees

@niden niden

Labels
5.0 The issues we want to solve in the 5.0 release breaks bc Functionality that breaks Backwards Compatibility bug A bug report status: medium Medium
Projects
None yet
Milestone
No milestone
2 participants
@niden @Jeckerson