Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T15515 Fix allow empty validation #15772

Merged
merged 5 commits into from
Nov 7, 2021
Merged

T15515 Fix allow empty validation #15772

merged 5 commits into from
Nov 7, 2021

Conversation

BeMySlaveDarlin
Copy link
Contributor

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Small description of change:
Fixed usage of allowEmpty option in common validation.

Thanks

@BeMySlaveDarlin BeMySlaveDarlin added the 5.0 The issues we want to solve in the 5.0 release label Nov 7, 2021
@BeMySlaveDarlin BeMySlaveDarlin self-assigned this Nov 7, 2021
@BeMySlaveDarlin BeMySlaveDarlin changed the title Issue/15515 fix allow empty validation T15515 Fix allow empty validation Nov 7, 2021
@BeMySlaveDarlin BeMySlaveDarlin linked an issue Nov 7, 2021 that may be closed by this pull request
[BUG]: Some Custom Validators don't handle the allowEmpty #15515
Closed
@BeMySlaveDarlin BeMySlaveDarlin mentioned this pull request Nov 7, 2021
Open
@BeMySlaveDarlin BeMySlaveDarlin linked an issue Nov 7, 2021 that may be closed by this pull request
[BUG]: allowEmpty for form validation does not work correctly when an entity is bound #15491
Open
@niden niden added bug A bug report status: medium Medium labels Nov 7, 2021
@niden niden merged commit 25999c6 into phalcon:5.0.x Nov 7, 2021
@niden
Copy link
Member

niden commented Nov 7, 2021

Thank you @BeMySlaveDarlin

@niden niden mentioned this pull request Nov 7, 2021
Closed
@BeMySlaveDarlin BeMySlaveDarlin deleted the issue/15515-fix-allow-empty-validation branch November 7, 2021 18:03
@niden niden mentioned this pull request Nov 8, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeckerson Jeckerson Jeckerson left review comments

@niden niden niden approved these changes

Assignees

@BeMySlaveDarlin BeMySlaveDarlin

Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium
Projects
None yet
Milestone
No milestone
3 participants
@BeMySlaveDarlin @niden @Jeckerson