Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T15785 change exists to has #15793

Merged
merged 6 commits into from
Nov 17, 2021
Merged

T15785 change exists to has #15793

merged 6 commits into from
Nov 17, 2021

Conversation

niden
Copy link
Member

@niden niden commented Nov 17, 2021

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Marked as deprecated:

  • Phalcon\Mvc\Model::existsBelongsTo()
  • Phalcon\Mvc\Model::existsHasMany()
  • Phalcon\Mvc\Model::existsHasOne()
  • Phalcon\Mvc\Model::existsHasOneThrough()
  • Phalcon\Mvc\Model::existsHasManyToMany()
  • Phalcon\Translate\Adapter\Csv::exists()
  • Phalcon\Translate\Adapter\Gettext::exists()
  • Phalcon\Translate\Adapter\NativeArray::exists()

Added:
- Phalcon\Mvc\Model::hasBelongsTo()
- Phalcon\Mvc\Model::hasHasMany()
- Phalcon\Mvc\Model::hasHasOne()
- Phalcon\Mvc\Model::hasHasOneThrough()
- Phalcon\Mvc\Model::hasHasManyToMany()
- Phalcon\Translate\Adapter\Csv::has()
- Phalcon\Translate\Adapter\Gettext::has()
- Phalcon\Translate\Adapter\NativeArray::has()

Thanks

@niden niden requested a review from Jeckerson November 17, 2021 19:56
@niden niden self-assigned this Nov 17, 2021
@niden niden added 5.0 The issues we want to solve in the 5.0 release new feature request Planned Feature or New Feature Request labels Nov 17, 2021
@niden niden linked an issue Nov 17, 2021 that may be closed by this pull request
@niden niden merged commit 4d4f793 into phalcon:5.0.x Nov 17, 2021
@niden niden deleted the T15785-change-exists-to-has branch November 17, 2021 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.0 The issues we want to solve in the 5.0 release new feature request Planned Feature or New Feature Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NFR]: Change exists to has
2 participants