Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T15842 volt compiler #15843

Merged
merged 3 commits into from
Dec 28, 2021
Merged

T15842 volt compiler #15843

merged 3 commits into from
Dec 28, 2021

Conversation

niden
Copy link
Member

@niden niden commented Dec 28, 2021

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Corrected Volt Compiler functionCall to first check for the container object before checking for the tag service.

Thanks

@niden niden added bug A bug report status: medium Medium 5.0 The issues we want to solve in the 5.0 release labels Dec 28, 2021
@niden niden requested a review from Jeckerson December 28, 2021 16:40
@niden niden self-assigned this Dec 28, 2021
@niden niden linked an issue Dec 28, 2021 that may be closed by this pull request
[BUG]: Volt Compiler throws RuntimeException - container related #15842
Closed
@niden niden merged commit 6fab5cd into phalcon:5.0.x Dec 28, 2021
@niden niden deleted the T15842-volt-compiler branch December 28, 2021 17:11
@niden niden mentioned this pull request Dec 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeckerson Jeckerson Jeckerson approved these changes

Assignees

@niden niden

Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Volt Compiler throws RuntimeException - container related
2 participants
@niden @Jeckerson