Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T15896 numeric input #15899

Merged
merged 3 commits into from
Feb 10, 2022
Merged

T15896 numeric input #15899

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1bf180e
corrected html helper numeric to produce number tags
niden Feb 10, 2022
d08f37e
updated changelog
niden Feb 10, 2022
5eb3d7c
correcting form tests
niden Feb 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG-5.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# [5.0.0rc1](https://github.com/phalcon/cphalcon/releases/tag/v5.0.0beta3) (xxxx-xx-xx)

## Fixed
- Fixed `Phalcon\Html\Helper\Input\Numeric` to produce correct elements [#15896](https://github.com/phalcon/cphalcon/issues/15896)

## Added
- Added `Phalcon\Encryption\Crypt::isValidDecryptLength($input)` to allow checking for the length of the decryption string [#15879](https://github.com/phalcon/cphalcon/issues/15879)

Expand Down
2 changes: 1 addition & 1 deletion phalcon/Html/Helper/Input/Numeric.zep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,5 @@ namespace Phalcon\Html\Helper\Input;
*/
class Numeric extends AbstractInput
{
protected type = "numeric";
protected type = "number";
}
4 changes: 2 additions & 2 deletions tests/integration/Forms/Element/RenderCest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,9 +121,9 @@ private function getExamples(): array
[
"Numeric",
Numeric::class,
'<input type="numeric" id=":name:" name=":name:" />',
'<input type="number" id=":name:" name=":name:" />',
['class' => 'alert alert-warning'],
'<input type="numeric" id=":name:" name=":name:" class="alert alert-warning" />',
'<input type="number" id=":name:" name=":name:" class="alert alert-warning" />',
],
[
"Password",
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/Html/Helper/Input/UnderscoreInvokeCest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ private function getClasses(): array
'hidden' => ['inputHidden', Hidden::class],
'image' => ['inputImage', Image::class],
'month' => ['inputMonth', Month::class],
'numeric' => ['inputNumeric', Numeric::class],
'number' => ['inputNumeric', Numeric::class],
'password' => ['inputPassword', Password::class],
'range' => ['inputRange', Range::class],
'search' => ['inputSearch', Search::class],
Expand Down