Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T15902 nativearray #15968

Merged
merged 2 commits into from
May 23, 2022
Merged

T15902 nativearray #15968

merged 2 commits into from
May 23, 2022

Conversation

niden
Copy link
Member

@niden niden commented May 23, 2022

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Added Phalcon\Translate\Adapter\Csv::toArray() and Phalcon\Translate\Adapter\NativeArray::toArray() to return the translation array back

Thanks

@niden niden changed the base branch from master to 5.0.x May 23, 2022 14:06
@niden niden requested a review from Jeckerson May 23, 2022 14:06
@niden niden self-assigned this May 23, 2022
@niden niden added new feature request Planned Feature or New Feature Request 5.0 The issues we want to solve in the 5.0 release labels May 23, 2022
@niden niden linked an issue May 23, 2022 that may be closed by this pull request
@niden niden merged commit 3d864e3 into phalcon:5.0.x May 23, 2022
@niden niden deleted the T15902-nativearray branch May 23, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.0 The issues we want to solve in the 5.0 release new feature request Planned Feature or New Feature Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NFR]: Get the internal translate array in Translate NativeArray
2 participants