Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: RawValue no longer supports mysql functions #16038

Merged
merged 2 commits into from
Aug 5, 2022
Merged

[BUG]: RawValue no longer supports mysql functions #16038

merged 2 commits into from
Aug 5, 2022

Conversation

ALameLlama
Copy link
Contributor

@ALameLlama ALameLlama commented Aug 3, 2022

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Small description of change:
I've updated the changed check on the Model.zep to have a separate comparison variable instead of overwriting the value, overwriting the value with the value->getValue() is turning it into a string and causing issues deeper in the update at phalcon\Db\Adapter\AbstractAdapter.zep:1198-1202

Instead of the placeholders[] being something like:
'`last_updated` = now()'

It's passing:
'`last_updated` = ?' and then passing 'now()' in the bind parameters

Thanks

@niden niden merged commit 40ff5c2 into phalcon:5.0.x Aug 5, 2022
@niden
Copy link
Member

niden commented Aug 5, 2022

Thank you @LlamaDuckGoose !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants