Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2002 Tag::linkTo() to allow the addition of query string parameters #2248

Merged
merged 2 commits into from
Apr 28, 2014
Merged

Fix #2002 Tag::linkTo() to allow the addition of query string parameters #2248

merged 2 commits into from
Apr 28, 2014

Conversation

dreamsxin
Copy link
Contributor

See #2002

@phalcon
Copy link
Collaborator

phalcon commented Apr 12, 2014

We need to pass those parameters to the Phalcon\Mvc\Url::get method instead of appending them to the query, could we implement it that way?

@dreamsxin dreamsxin closed this Apr 14, 2014
@dreamsxin dreamsxin reopened this Apr 14, 2014
@dreamsxin
Copy link
Contributor Author

@phalcon I change to use Phalcon\Mvc\Url::get

phalcon pushed a commit that referenced this pull request Apr 28, 2014
Fix #2002 Tag::linkTo() to allow the addition of query string parameters
@phalcon phalcon merged commit a3bb614 into phalcon:1.3.2 Apr 28, 2014
@phalcon
Copy link
Collaborator

phalcon commented Apr 28, 2014

Could you please submit this to 2.0.0?

@dreamsxin dreamsxin deleted the tag_1.3.2 branch April 16, 2015 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants