Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align setting of brunnel (and layer) tags for brunnel features depending on their length and zoom level #18

Merged
merged 20 commits into from
Oct 26, 2023

Conversation

phanecak-maptiler
Copy link
Owner

This re-implements following OpenMapTiles pull-request into planetiler-openmaptiles:

Some screenshot, roughly same area as in "1579", same zoom levels:

Screenshot from 2023-10-10 16-20-49

Side note: As per "This PR restores missing transportation_name features that are missing from zoom 11 ..." that is actually not needed since planetiler-openmaptiles seems to be doing that already. What this PR actually does is aligning setting of brunnel (and layer) tags for brunnel features depending on their length: approx. 2% of the tile size is the threshold, if over it, tags are set. This actually decreases tile size a little, since tags are no longer being set for small features at lower zoom levels.

@phanecak-maptiler phanecak-maptiler self-assigned this Oct 10, 2023
@phanecak-maptiler phanecak-maptiler marked this pull request as draft October 10, 2023 14:27
@phanecak-maptiler
Copy link
Owner Author

For now setting this PR as "draft" since my current results match what is in OMT PR in the "Current Release" screenshot. I also get the same when using OpenMapTiles from current master (e.g. with "1579" merged). Hence there is for now a mystery regarding how to achieve output matching "After this PR" screenshot.

@phanecak-maptiler phanecak-maptiler changed the title Omt3 15 frag fix Align setting of brunnel (and layer) tags for brunnel features depending on their length and zoom level Oct 12, 2023
@phanecak-maptiler phanecak-maptiler marked this pull request as ready for review October 12, 2023 16:24
... (as per OMT PR 1486)

But FERRY_MIN_PIXEL_SIZE is "too much" in the contexct of Planetiler,
since it is applied within tiles, hence causes gaps in lines if a line
"strikes a little" certain tile. Hence we will need to divert a little.
hence the results are much closer to what OMT is doing for Z4-Z9
ferry test polygon with area 1 now qualifies for min. zoom 5
@phanecak-maptiler phanecak-maptiler marked this pull request as draft October 18, 2023 13:47
@phanecak-maptiler phanecak-maptiler marked this pull request as ready for review October 23, 2023 12:49
@phanecak-maptiler phanecak-maptiler merged commit d3434f9 into omt_3_15_0 Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant