Align setting of brunnel (and layer) tags for brunnel features depending on their length and zoom level #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ding on feature size (matching OMT PR 1579)
…er available at Z8
|
For now setting this PR as "draft" since my current results match what is in OMT PR in the "Current Release" screenshot. I also get the same when using OpenMapTiles from current |
phanecak-maptiler
changed the title
... (as per OMT PR 1486) But FERRY_MIN_PIXEL_SIZE is "too much" in the contexct of Planetiler, since it is applied within tiles, hence causes gaps in lines if a line "strikes a little" certain tile. Hence we will need to divert a little.
hence the results are much closer to what OMT is doing for Z4-Z9
ferry test polygon with area 1 now qualifies for min. zoom 5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-implements following OpenMapTiles pull-request into
planetiler-openmaptiles:Some screenshot, roughly same area as in "1579", same zoom levels:
Side note: As per "This PR restores missing transportation_name features that are missing from zoom 11 ..." that is actually not needed since
planetiler-openmaptilesseems to be doing that already. What this PR actually does is aligning setting ofbrunnel(andlayer) tags for brunnel features depending on their length: approx. 2% of the tile size is the threshold, if over it, tags are set. This actually decreases tile size a little, since tags are no longer being set for small features at lower zoom levels.