Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmProcess is nil in Image built on Windows, then started on Linux #78

Closed
daniels220 opened this issue Nov 29, 2023 · 0 comments · Fixed by #79
Closed

vmProcess is nil in Image built on Windows, then started on Linux #78

daniels220 opened this issue Nov 29, 2023 · 0 comments · Fixed by #79

Comments

@daniels220
Copy link
Contributor

OSSVMProcess>>initialize bails altogether on Windows, meaning that if OSSubprocess is installed on Windows, and the image is saved and later started on Linux, the VMProcess is not initialized. Less importantly, if an image is built and saved on Linux, then started on Windows, the old VMProcess sticks around, retaining values from the previous session.

Seems like a simple enough fix to:

  1. Always registerToolClassNamed: regardless of the platform we're installing on.
  2. In startUp:, nil the old VMProcess after finalizePreviousSession, then initialize a new one only on not-Windows. This is a change from the current Linux behavior of reusing the old instance, but it seems like most or all instance variables are overwritten in initialize, and any that aren't seem more likely to be the cause of a bug than anything.

PR incoming shortly.

jecisc added a commit that referenced this issue Nov 30, 2023
Better support for moving images between Windows and Linux (fixes #78)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant