Moved builder pattern to analysis class, and refactored how test classes are managed at instanciation #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 10, 2024 17:01
…ses that are not test classes are not ignored
Pull Request Test Coverage Report for Build 7486755453
💛 - Coveralls |
guillep
reviewed
Jan 11, 2024
| { #category : 'initialize-release' } | ||
| MutationTestingAnalysis >> initializeFor: someTestCasesReferences mutating: someModelClasses using: operatorCollection with: aTestSelectionStrategy with: aMutantSelectionStrategy loggingIn: aLogger budget: aBudget [ | ||
| { #category : 'initialization' } | ||
| MutationTestingAnalysis >> initialize [ |
guillep
reviewed
Jan 11, 2024
| @@ -590,24 +656,48 @@ MutationTestingAnalysis >> stopOnErrorOrFail: aBoolean [ | |||
| stopOnErrorOrFail := aBoolean | |||
| ] | |||
|
|
|||
| { #category : 'accesing' } | |||
| { #category : 'accessing' } | |||
There was a problem hiding this comment.
haha even noticing typos in the protocols!
There was a problem hiding this comment.
I must admit, the warnings before committing helped me a bit ahah
guillep
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59, fixes #61
Put builder pattern in the
MutationTestingAnalysisclass and removedMutationTestingAnalysisBuilderclass.Also changed
testCasesFrom:method so that classes that are not test classes and are given as test classes when creating an analysis are not ignored. The method let them in, but the analysis eventually crashes with a DNU message.