Fix: replace class side API implementation

[guillep]

And some incompatible with Pharo12

[coveralls]

Pull Request Test Coverage Report for Build 7491128361

• 13 of 19 (68.42%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 58.337%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/MuTalk-Model/MutationTestingAnalysis.class.st	5	11	45.45%

Totals
Change from base Build 7489850629:	0.0%
Covered Lines:	3859
Relevant Lines:	6615

---

💛 - Coveralls

[DurieuxPol]

Indeed I forgot to replace the class side API, thanks !
However the aBloc millisecondsToRun code doesn't seem to work in pharo 10.

[guillep]

Auch, true! It only works in Pharo 12!
And the thing is that the old API does not work in Pharo12!

I'll fix it :)

[DurieuxPol]

Maybe if we use deprecated:transformWith: instead of deprecated: for deprecated methods, it will work ?

[guillep]

That will rewrite users. We need a version that works for all Pharo versions.
There are not many solutions, and there are no magical ones ;)

• option 1: we choose our "good" api and provide a compatibility package that introduces it in the version it does not exist
• option 2: we add an if per version (if Pharo 12 we do this, otherwise we do that)
• option 3: we rely on a lower level API that is compatible but maybe not so nice to read

[guillep]

Now, since this is for a little method, I'm for option 2 :)

If we had incompatibilities in the compiler or some more complex stuff, or in something we use a lot then I would have a different opinion maybe.

[guillep]

Actually, there is timeToRun that is compatible in all pharo versions and returns a duration instead of an integer.
Which comes in handy because mutalk is taking the integer and converting it manually to a duration, so now there is no need for that. So Option 3ish it was!

[DurieuxPol]

Ok nice !
So everything works as intended now right ?

[guillep]

Well tests are green, in the CI, and in my machine in P12.
We should look forward to add the P12 CI.