Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated file logger #77

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Conversation

DurieuxPol
Copy link
Collaborator

Updated MTAnalysisFileLogger with new file managing system.
You can use it like that:

analysis := MTAnalysis new
	            classesToMutate: { UUID };
	            testClasses: { UUIDTest };
	            logger: (MTAnalysisFileLogger toFileNamed: 'log.txt').
analysis run

@guillep guillep closed this Feb 14, 2024
@guillep guillep reopened this Feb 14, 2024
@guillep
Copy link
Contributor

guillep commented Feb 14, 2024

Updated MTAnalysisFileLogger with new file managing system.

Haha! New! Since a couple of years already ^^

Copy link
Contributor

@guillep guillep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the formatting :)

analysis run.

self assert: logFile exists.
logFile delete
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @DurieuxPol it should be better to put the delete in a tearDown method.
Otherwise, if the test fails for some reason, the system will remain dirty. (and the test will never pass then)

@guillep guillep closed this Feb 14, 2024
@guillep guillep reopened this Feb 14, 2024
@guillep
Copy link
Contributor

guillep commented Feb 14, 2024

@inao0 will be interested in this PR.

@guillep guillep merged commit 2e3ec99 into pharo-contributions:master Feb 14, 2024
4 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants