Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression on BlCursor #403

Closed
ELePors opened this issue Jan 17, 2024 · 7 comments · Fixed by #404
Closed

Regression on BlCursor #403

ELePors opened this issue Jan 17, 2024 · 7 comments · Fixed by #404

Comments

@ELePors
Copy link

ELePors commented Jan 17, 2024

Hi,

All zones of my UI where i change the cursor is broken with latest version of Bloc.

exemple
myBlSpace currentCursor: BlCursor crosshair

BlCursor does not exist anymore... it was existent some month ago.
Thanks by advance.

Eric

@labordep
Copy link
Contributor

We have also this problem in Toplo: pharo-graphics/Toplo#84

@tinchodias
Copy link
Collaborator

@ELePors and @labordep I'm sorry, this is because I merged this PR: #400
Shouldn't merge it so fast / without deprecation.

That BlCursor crosshair should be now Cursor crossHair.

I'm between reverting the PR or re-adding BlCursor with a deprecation message.

@labordep
Copy link
Contributor

Thanks @tinchodias!
We are enthusiastic about these developments, but please don't remove classes without a deprecation phase!

jecisc added a commit that referenced this issue Jan 18, 2024
Fixes #403 

Sorry for the inconvenance
@tinchodias
Copy link
Collaborator

@ELePors @labordep now BlCursor exists again, with automatic rewriting deprecation that converts to "Cursor *". Do you think it's okay?

@tinchodias
Copy link
Collaborator

I tested BlCursor on my image with:

selectors := BlCursor class selectors.

c := Object subclass: #PruebaCursor.
selectors do: [ :each |
	c compile: ('{1} ^ BlCursor {1}' format: { each }) ].

selectors collect: [ :each |
	each -> (c new perform: each) ].

and seemed to work fine

@labordep
Copy link
Contributor

Thanks!
I think this is ok if the two classes are equivalent.

@ELePors
Copy link
Author

ELePors commented Jan 22, 2024

Thanks Martin, it's good !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants