Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing Sparta #202

Merged
merged 31 commits into from
Jan 6, 2023
Merged

Removing Sparta #202

merged 31 commits into from
Jan 6, 2023

Conversation

tinchodias
Copy link
Collaborator

It seems to work well. It is almost ready, for the case somebody wants to try it (@plantec).

@tinchodias
Removed sparta as dependency. This should fail!
8eff1ec
@tinchodias
Convert visualBounds* and strokedBounds* family to generic Bloc
449164b
@tinchodias
Convert family of containsPoint:* protocol to Bloc
0659fc8
@tinchodias
Convert offscreenMeasureTextParagraph: to Bloc
e72cb4c
@tinchodias
Migrated Bloc-Exporter to Alexandrie
d785354
@tinchodias
Remove a new tools inspection on SpartaCanvas
cd5ddf8
@tinchodias
Remove references to preferableSpartaCanvas
5e9524e
@tinchodias
Remove Bloc-Sparta package!
16ef34e
@tinchodias
Remove many unused "system" extensions
f7e6b7e
@tinchodias
Re-add "Bloc-Exporter" package in baseline
e79efd5
@tinchodias
Don't load Bloc-Compositor-Examples
bd7c30e
@tinchodias
Delete package Bloc-Composition and its examples
54d23fd
@tinchodias
Add two required methods from Bloc-Compositor
d02f059
@tinchodias
Add Form>>stride, required by BlocHost-Morphic
035048e 
(from Sparta)
@tinchodias
Group "api - compositing" methods in BlElement
5345346
@tinchodias
Make bloc-Alexandrie hosts independent from Sparta specific code
a4b1570
@tinchodias
Add class comments + use BA hosts by default
6d068f9
@tinchodias
Remove hosts tied to sparta & two BA diff inspectors
805a5ec
@tinchodias
Remove BlMorphicHost, unused.
03988fc
@tinchodias
Convert Bloc-Alexandrie hosts to Bloc, and make generic.
11f3e55 
Generic for the future... there is only one option now, BARenderer...
but it's determined without hardcoding it, via a query from the top superclass.
System setting would be required here.

Rename:
useAlexandrieMorphicWindowHost -> useMorphicHost
useAlexandrieOSWindowSDL2Host -> useSDL2Host

Also changed hosts labels
@tinchodias
The "use*Host" protocol must be extension
9b47ba1
@tinchodias
Use System Settings to choose a BlHostRenderer
d18f747
@tinchodias
Recover BlMorphicHost
fc12d74 
It can be still useful to show spaces in Spec2 w/Morphic backend
@tinchodias
System Settings: Move preferableHostClass to BlHost
8eb031a
@tinchodias
BlHostRendererSurface hierarchy is not used... tag it as a reminder
302123c
@tinchodias
System Settings: Move preferableEventHandlerRegistry to BlHandlerRegi…
855548d 
…stry
@plantec
Copy link
Collaborator

plantec commented Dec 29, 2022

'Hello' asRopedText asElement openInNewSpace
leads to
BlTextElementMeasurer>>measureTextParagraph: aBlTextParagraph of: aTextElement
self subclassResponsibility

Capture d’écran 2022-12-29 à 22 20 55

@tinchodias
Copy link
Collaborator Author

@plantec sorry, fixed now.
To write previous message, I only preformed tests without text, apparently... too bad!

@plantec
Copy link
Collaborator

plantec commented Dec 30, 2022

all seem ok now. thanks.

@tinchodias tinchodias merged commit 48f96ec into dev-1.0 Jan 6, 2023
@tinchodias
Copy link
Collaborator Author

So, merged it!

@tinchodias tinchodias deleted the rmsparta branch January 6, 2023 20:01
@tinchodias tinchodias mentioned this pull request Jan 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tinchodias @plantec