618-Bloc-Main-Thread-should-be-stopped-and-restarted-in-shutdownstartup #619
Conversation
tesonep
commented
Oct 10, 2024
tesonep
commented
- Adding support for stoping and starting the Bloc thread during image startup / shutdown
- Recovering open spaces in the same place
- Fixing Tests
- Showing an space that has been hide should work
…e startup / shutdown - Recovering open spaces in the same place - Fixing Tests - Showing an space that has been hide should work
There was a problem hiding this comment.
@tesonep I put some comments but I consider okay to merge and then take eventually actions.
I'll wait until tomorrow
| { #category : #'startup - shutdown' } | ||
| BlSpace >> rememberVisibleStatus [ | ||
|
|
||
| previousVisibleStatus := self isVisible |
There was a problem hiding this comment.
I trust in your solution, but I didn't realize yet why isVisible is not enough, and we need a new flag
There was a problem hiding this comment.
Because we need to store the flag. Once the real window is destroyed / do not exist in the starting image, the window is always not visible. We need to know how it was before saving the image. Thanks for the review. I tried to avoid it but the space only delegates this behaviour to the real window.
| { #category : #'startup - shutdown' } | ||
| BlSpaceManager >> start [ | ||
|
|
||
| spaces do: [ :aSpace | aSpace ensureWindowOpen ] |
There was a problem hiding this comment.
This class has the only sends of ensureWindowOpen and rememberVisibleStatus. Maybe previousVisibleStatus flag fits better here in BlSpaceManager instead of BlSpace. It is here where this previousVisibleStatus is stored and restored.
There was a problem hiding this comment.
The visible status is of the window (aka the space) if we put the flag in the space manager we need a collection of flags (one per each space).
There was a problem hiding this comment.
Thanks for the review. We need to store the state of the open windows if we want to reopen in the same place.
|
Fixes #618 |
👍 Thanks! |
tinchodias
deleted the
618-Bloc-Main-Thread-should-be-stopped-and-restarted-in-shutdownstartup
branch
| aSpace isOpened ifTrue: [ ^ self ]. | ||
| aSpace isOpened ifTrue: [ | ||
| "If it has been already opened, just unhide it" | ||
| aSpace hostSpace show. | ||
| ^ self ]. |
There was a problem hiding this comment.
I want to review this change together with #636. Maybe what needed to happen in this case is to attach the space to the universe as if it was a host switch.
