allowMousePickOutsideEvent/preventMousePickOutsideEvent are now switc…

…hed on popup window open/close
pharo-graphics · Nov 4, 2024 · b520ac4 · b520ac4
1 parent 639b020
commit b520ac4
Show file tree

Hide file tree

Showing 6 changed files with 27 additions and 12 deletions.
diff --git a/src/Toplo-Widget-Menu/ToMenuWindow.class.st b/src/Toplo-Widget-Menu/ToMenuWindow.class.st
@@ -1,6 +1,6 @@
 Class {
 	#name : #ToMenuWindow,
-	#superclass : #ToAnchoredWindow,
+	#superclass : #ToPopupWindow,
 	#instVars : [
 		'openedSubmenuWindow'
 	],

diff --git a/src/Toplo-Widget-Select/ToSelectPopupWindow.class.st b/src/Toplo-Widget-Select/ToSelectPopupWindow.class.st
@@ -1,6 +1,6 @@
 Class {
 	#name : #ToSelectPopupWindow,
-	#superclass : #ToAnchoredWindow,
+	#superclass : #ToPopupWindow,
 	#category : #'Toplo-Widget-Select-List'
 }
 

diff --git a/src/Toplo/BlElement.extension.st b/src/Toplo/BlElement.extension.st
@@ -444,12 +444,15 @@ BlElement >> stillPressedStartDelay [
 
 { #category : #'*Toplo' }
 BlElement >> stillPressedStartDelay: aDuration [
-
 	" must have a skin state generator "
+
 	self userData at: #stillPressedStartDelay put: aDuration asDuration.
+	self flag: 'To check'.
 	" one have to allow mouse pick outside event to make it possible stopping 
 	the dedicated task from the skin state generator (ToSkinStateGenerator) "
-	aDuration ifNil: [ self preventMousePickOutsideEvent ] ifNotNil: [ self allowMousePickOutsideEvent ]
+	aDuration
+		ifNil: [ self preventMousePickOutsideEvent ]
+		ifNotNil: [ self allowMousePickOutsideEvent ]
 ]
 
 { #category : #'*Toplo' }

diff --git a/src/Toplo/ToPopupWindow.class.st b/src/Toplo/ToPopupWindow.class.st
@@ -0,0 +1,19 @@
+Class {
+	#name : #ToPopupWindow,
+	#superclass : #ToAnchoredWindow,
+	#category : #'Toplo-Core-Window'
+}
+
+{ #category : #'api - displaying' }
+ToPopupWindow >> close [ 
+
+	windowManager element preventMousePickOutsideEvent.
+	super close
+]
+
+{ #category : #'api - displaying' }
+ToPopupWindow >> popupEvent: anEvent [
+
+	windowManager element allowMousePickOutsideEvent.
+	^ super popupEvent: anEvent
+]
diff --git a/src/Toplo/ToPopupWindowManager.class.st b/src/Toplo/ToPopupWindowManager.class.st
@@ -178,13 +178,6 @@ ToPopupWindowManager >> mouseUpOutsideEvent: anEvent [
 	self pickOutsideEvent: anEvent
 ]
 
-{ #category : #'api - hooks' }
-ToPopupWindowManager >> onInstalledIn: anElement [
-
-	super onInstalledIn: anElement.
-	anElement allowMousePickOutsideEvent.
-]
-
 { #category : #'event handling' }
 ToPopupWindowManager >> pickOutsideEvent: anEvent [
 	" 

diff --git a/src/Toplo/ToTooltipWindow.class.st b/src/Toplo/ToTooltipWindow.class.st
@@ -1,6 +1,6 @@
 Class {
 	#name : #ToTooltipWindow,
-	#superclass : #ToAnchoredWindow,
+	#superclass : #ToPopupWindow,
 	#category : #'Toplo-Core-Tooltip'
 }