Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace BLRBTextStyler by Shout #88

Closed
jecisc opened this issue Jan 25, 2024 · 7 comments
Closed

Replace BLRBTextStyler by Shout #88

jecisc opened this issue Jan 25, 2024 · 7 comments

Comments

@jecisc
Copy link
Member

jecisc commented Jan 25, 2024

It would be nice to use the text styler of Pharo instead of having one specific to Album to reduce duplication and the need to maintain two stylers. (Alain agreed)

@tinchodias
Copy link
Collaborator

Are you interested on this task @jecisc ?

@jecisc
Copy link
Member Author

jecisc commented Apr 10, 2024

I tried to do it already but examples using syntax highlight were broken so and I did not know Toplo enough to do the change "in the dark".

I'm interested to do it but I don't have the time right now and I'll have a few weeks of holidays soon

@tinchodias
Copy link
Collaborator

The deprecation message in the trait that BlRBTextStyler uses, suggests creating a subclass of RBProgramNodeVisitor. Is this the Shout solution?

@tinchodias
Copy link
Collaborator

Okay, I wrote too fast: immediately I've found SHRBTextStyler

@tinchodias
Copy link
Collaborator

The main particularity I detect when I read the code of BlRBTextStyler in reference to SHRBTextStyler is creating instances in the hierarchy of BlTextLinkAttribute. But, as you can see in the screen capture... this hierarchy is stub, it does nothing special; it ignores the names it receives:

Screenshot 2024-07-04 at 12 48 33

tinchodias added a commit to pharo-graphics/Bloc that referenced this issue Jul 4, 2024
* This fixes a loading error in Pharo 13 due to removed TRBProgramNodeVisitor. See #548.
* See also: pharo-graphics/Toplo#88
tinchodias added a commit to pharo-graphics/Bloc that referenced this issue Jul 4, 2024
* This fixes a loading error in Pharo 13 due to removed TRBProgramNodeVisitor. See #548.
* See also: pharo-graphics/Toplo#88
@plantec
Copy link
Collaborator

plantec commented Sep 28, 2024

what is the status of this issue ?

@tinchodias
Copy link
Collaborator

Ah this is closed by pharo-graphics/Bloc#549

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants