Composed image format: C translation #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PalumboN
commented
Feb 22, 2022
Comment on lines
90
to
111
| { #category : #'file primitives' } | ||
| AbstractComposedImageAccess >> fscanf: file _: format _: varHolder [ | ||
|
|
||
| <doNotGenerate> | ||
| ^ (format = headFormat) | ||
| ifTrue: [ | ||
| varHolder contents: (file nextLine substrings: ' ') first ]; | ||
| yourself | ||
| ] | ||
|
|
||
| { #category : #'file primitives' } | ||
| AbstractComposedImageAccess >> fscanf: file _: format _: varHolder1 _: varHolder2 [ | ||
|
|
||
| <doNotGenerate> | ||
| ^ (format = fieldFormat) | ||
| ifTrue: [ | ||
| | dataArray | | ||
| dataArray := file nextLine substrings: '#:,'. | ||
| (dataArray first = '}') ifTrue: [ ^false ]. | ||
| varHolder1 contents: dataArray second trimLineSpaces. | ||
| varHolder2 contents: dataArray third trimLineSpaces asInteger ]; | ||
| yourself |
There was a problem hiding this comment.
Should we implement it for real? (Read based to a format)
PalumboN
commented
Feb 22, 2022
|
|
||
| pageSize = getpagesize(); | ||
| pageMask = ~(pageSize - 1); | ||
|
|
||
| heapLimit = valign(max(desiredHeapSize, 1)); | ||
| heapLimit = valign(max(desiredHeapSize, 1)) + pageSize; // Add 1 page more just in case (G & N) |
There was a problem hiding this comment.
We started to fix this with Guille, but is not working yet.
PalumboN
changed the title
…lk-vm into composed-format-c-translation
|
Now in CI I have this error (about trampolines (?) ) compiling C code But I can't reproduce it locally :( |
Just for the record, we did. It was the non JIT VM that had a different definition of longjmp, together with the C11 upgrade. |
|
Now it compiles in OSX and linuex but not windows: |
|
Yes, it seems that |
|
I think that I could solve the problems, but the CI is not building my last commit: It filled the disk again? 😞 |
hogoww
added a commit
to hogoww/opensmalltalk-vm
that referenced
this pull request
Feb 26, 2022
…hod [ newObjectHash ] 20 test cases.
hogoww
added a commit
to hogoww/opensmalltalk-vm
that referenced
this pull request
Feb 26, 2022
…od [ newObjectHash ] 1/20 Test Cases are NOT EQUIVALENT
|
Massive ! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making C translation available for new Composed image Reader/Writer.
The translation
worksfinishes and generate C code, but there is still some issues:Use(not working on Mac 🍎 💀)sscanf_sinstead ofsnprintfto avoid overflows,\n)