Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improving-permSpace #614

Merged
merged 6 commits into from
Jun 20, 2023
Merged

improving-permSpace #614

merged 6 commits into from
Jun 20, 2023

Conversation

tesonep
Copy link
Collaborator

@tesonep tesonep commented Jun 8, 2023

  • In bulk move to perm space we generate the remembered set at the end only
  • Adding Statistics
  • Adding tests

@tesonep
- Adding tests
76ab9ea 
- In bulk move to perm space we generate the remembered set at the end only
- Adding Statistics
@tesonep
Fixing Windows build
58164e7
guillep
guillep reviewed Jun 9, 2023
View reviewed changes
smalltalksrc/VMMaker/VMRememberedSet.class.st Outdated
@@ -137,7 +152,7 @@ VMRememberedSet >> growRememberedSet [
newObj ifNil:
[newObj := manager allocatePinnedSlots: numSlots + 1024.
newObj ifNil:
[(manager growOldSpaceByAtLeast: numSlots + 1024) ifNil: [self error: 'could not grow remembered set'].
[(manager growOldSpaceByAtLeast: (numSlots + 1024) * self wordSize) ifNil: [self error: 'could not grow remembered set'].
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch here

guillep
guillep approved these changes Jun 9, 2023
View reviewed changes
Copy link
Member

@guillep guillep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a superficial review, it looks ok, I don't have enough knowledge to make a deeper one. I trust your tests ;)

@tesonep tesonep changed the title improving-permSpace [WIP] improving-permSpace Jun 16, 2023
@tesonep
- Adding duplicates when migrating form Perm->New RememberedSet to Pe…
fd435a4 
…rm->Old

- Removing duplicates using the mark bit
- Adding statistics for the Perm->New Remembered Set
@tesonep
- Invalidating Become of PermanentObjects.
fceaa04 
- Improving the cleanup of Perm to old remembered set.
- Handling duplicates in the Perm to old remembered set.
@tesonep tesonep changed the title [WIP] improving-permSpace improving-permSpace Jun 20, 2023
@tesonep tesonep merged commit d3edbcc into pharo-10 Jun 20, 2023
@tesonep tesonep deleted the improving-permSpace branch June 20, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillep guillep guillep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tesonep @guillep