Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backporting PR for allocating in the old space #709

Merged
merged 12 commits into from
Feb 17, 2024
Merged

Backporting PR for allocating in the old space #709

merged 12 commits into from
Feb 17, 2024

Conversation

jordanmontt
Copy link
Member

@jordanmontt jordanmontt mentioned this pull request Nov 8, 2023
Closed
3 tasks
guillep
guillep approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@guillep guillep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to me!

@guillep
Copy link
Member

guillep commented Nov 8, 2023

It does not compile:

/Users/lse/Workspace/workspace/pharo-vm_backport-pr-new-old/build/generated/64/vm/src/gcc3x-cointerp.c:47568:16: error: implicit declaration of function 'formatOfClassSafe' is invalid in C99 [-Werror,-Wimplicit-function-declaration]

        classFormat = formatOfClassSafe(classObj);

We need to use formatOfClass, formatOfClassSafe does not exist in this branch.

@jordanmontt
Copy link
Member Author

It should be good by now!

@tesonep tesonep merged commit 55f077d into pharo-10 Feb 17, 2024
2 of 3 checks passed
@tesonep tesonep deleted the backport-pr-new-old branch February 17, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillep guillep guillep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jordanmontt @guillep @tesonep