Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix function pointer comparison warning #783

Merged
merged 2 commits into from
May 2, 2024
Merged

Fix function pointer comparison warning #783

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
731a652
Fix function pointer comparison with cast
guillep Apr 30, 2024
c6fdaa5
re enable warning incompatible-pointer-types
guillep Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,6 @@ add_compile_options(
-Wno-incompatible-function-pointer-types
-Wno-return-type
-Wno-unused-local-typedef
-Wno-incompatible-pointer-types
-Wno-shift-negative-value
-Wno-unknown-warning-option
)
Expand Down
2 changes: 1 addition & 1 deletion smalltalksrc/VMMaker/SimpleStackBasedCogit.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -952,7 +952,7 @@ SimpleStackBasedCogit >> compilePrimitive [
((primitiveRoutine := coInterpreter
functionPointerForCompiledMethod: methodObj
primitiveIndex: primitiveIndex) = 0 or: [
primitiveRoutine = #primitiveFail ]) ifTrue: [
primitiveRoutine = (self cCoerceSimple: #primitiveFail to: #'void *') ]) ifTrue: [
^ self genFastPrimFail ]. "no primitive"
minValidCallAddress := minValidCallAddress min:
primitiveRoutine asUnsignedInteger.
Expand Down