Remove warnings c compiler #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillep
reviewed
May 2, 2024
Comment on lines
-2309
to
+2313
| return ((isBytes(socketOop)) | ||
| && ((byteSizeOf(socketOop)) == (sizeof(SQSocket))) | ||
| ? ((SocketPtr) (firstIndexableField(socketOop))) | ||
| : (primitiveFailFor(PrimErrBadArgument), | ||
| null)); | ||
| if ((isBytes(socketOop)) && ((byteSizeOf(socketOop)) == (sizeof(SQSocket)))) { | ||
| return (SocketPtr) (firstIndexableField(socketOop)); | ||
| } | ||
| primitiveFailFor(PrimErrBadArgument); | ||
| return null; |
There was a problem hiding this comment.
Why would this rewrite remove the warning? do you know?
There was a problem hiding this comment.
Because there is not the expression with the complex type I guess (split into many statements)
guillep
reviewed
May 2, 2024
| @@ -14736,6 +14736,7 @@ StackInterpreter >> stackPointerIndexForFrame: theFP [ | |||
| <var: #theFP type: #'char *'> | |||
| <var: #thePage type: #'StackPage *'> | |||
| <var: #theSP type: #'char *'> | |||
| <returnTypeC: #sqInt> | |||
There was a problem hiding this comment.
Oh yes :)
Is this a problem with the type inferencer? Something worth improving there as a separate issue?
There was a problem hiding this comment.
It's not just the type inferer, the problem is to have char* types in pointers to the stack (the type inference is doing good it's work).
I already opened an issue for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bye flags for warnings:
-Wno-conditional-type-mismatch-Wno-incompatible-pointer-typesAnd fixing other warnings from C compiler