Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Primitive format #802

Merged
merged 5 commits into from
Jun 4, 2024
Merged

Primitive format #802

merged 5 commits into from
Jun 4, 2024

Conversation

doste
Copy link
Collaborator

@doste doste commented May 7, 2024

The new primitive gives us the format of an object. It's implemented in both the interpreter and the JIT.
Also I added a few tests.

Copy link
Member

@guillep guillep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! We can sit together to see the things I marked!

…oncretizeMoveMbrR method, it doesn't need to move a 0 because it concretizes to the 'LDURB' instruction which zero-extends the value
Copy link
Member

@guillep guillep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good!!

@guillep guillep merged commit 49e95fa into pharo-project:pharo-10 Jun 4, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants