Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change last assertion in #test2 on LibTTYTest to use an empty environment to avoid translation of the error message #17138

Closed
wants to merge 2 commits into from

Conversation

Rinzwind
Copy link
Contributor

This pull request changes last assertion in #test2 on LibTTYTest to use an empty environment to avoid translation of the error message (issue #17127).

…nment to avoid translation of the error message (issue pharo-project#17127).
@Rinzwind
Copy link
Contributor Author

Seems I misunderstood the problem as the test still failed in build 1.

@Rinzwind
Copy link
Contributor Author

The test still failed in build 2 as well. I temporarily added commit c8360a0 to get info on the locale environment.

@Rinzwind
Copy link
Contributor Author

Output of the commands added in commit c8360a0 in build 3:

+ locale
LANG=fr_FR.UTF-8
LANGUAGE=
LC_CTYPE="fr_FR.UTF-8"
LC_NUMERIC="fr_FR.UTF-8"
LC_TIME="fr_FR.UTF-8"
LC_COLLATE="fr_FR.UTF-8"
LC_MONETARY="fr_FR.UTF-8"
LC_MESSAGES="fr_FR.UTF-8"
LC_PAPER="fr_FR.UTF-8"
LC_NAME="fr_FR.UTF-8"
LC_ADDRESS="fr_FR.UTF-8"
LC_TELEPHONE="fr_FR.UTF-8"
LC_MEASUREMENT="fr_FR.UTF-8"
LC_IDENTIFICATION="fr_FR.UTF-8"
LC_ALL=
+ locale -a
C
C.utf8
fr_FR.utf8
POSIX

@Rinzwind Rinzwind marked this pull request as draft September 19, 2024 19:29
@jecisc
Copy link
Member

jecisc commented Sep 20, 2024

Thank you for working on this! This kind of issues can take us a lot of time and it's really great to have some help on those! :3

@Rinzwind
Copy link
Contributor Author

No problem, I took a look as I added LibTTYTest in pull request #16427.

@demarey
Copy link
Contributor

demarey commented Sep 27, 2024

The locale of one worker running the tests had the locale FR instead of US.
I just fixed that. So, tests hould now pass.
As @Rinzwind suggested, tests could specify the locale they expect to avoid that but that is not the plan for now.
I'm closing the PR.
Thanks @Rinzwind for taking time to investigate this problem.

@demarey demarey closed this Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants