Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not open a debugger if libgit2 is not present #1731

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

estebanlm
Copy link
Collaborator

... at least, not immediately :)
instead, react in a nicer way. For now I made this:

image

@estebanlm
Copy link
Collaborator Author

@tesonep ping ;)

@Ducasse
Copy link
Collaborator

Ducasse commented Sep 5, 2023

Esteban you have tests failing.

###########
# Summary #
###########

IceTipWorkingCopyBrowserOnUpdatedRepoTest
 ✗ #testItemsHasContextMenu (240ms)
 ✗ #testPackageHasBrowseRepositoryVersionOption (233ms)
 ✗ #testPackageIsShownInList (236ms)
 ✗ #testStatusBarShowsStatusOfRepository (246ms)

IceTipRepositoriesBrowserTest
 ✗ #testAddRepositoryInModelWithoutRefreshDoesNotRefreshList (283ms)
 ✗ #testAddRepositoryInModelWithoutRefreshDoesNotShowNewRepository (258ms)
 ✗ #testAddRepositoryThenRefreshShowsNewRepository (259ms)
 ✗ #testEditRepositoryBranchThenRefreshDoesRefreshList (254ms)
 ✗ #testEditRepositoryBranchWithoutRefreshDoesNotRefreshList (254ms)
 ✗ #testEditRepositoryNameThenRefreshDoesRefreshList (254ms)
 ✗ #testEditRepositoryNameWithoutRefreshDoesNotRefreshList (255ms)
 ✗ #testEditRepositoryStatusThenRefreshDoesRefreshList (254ms)
 ✗ #testEditRepositoryStatusWithoutRefreshDoesNotRefreshList (252ms)
 ✗ #testHasAddButtonOnTheRight (254ms)
 ✗ #testHasFetchAllButtonOnTheLeft (254ms)
 ✗ #testHasSettingsButtonOnTheRight (246ms)
 ✗ #testInitialListShowsElementsInOriginalOrder (249ms)
 ✗ #testListHasContextMenuHasPackagesOptionEnabled (256ms)
 ✗ #testListHasContextMenuHasRepairRepositoryOptionDisabled (258ms)
 ✗ #testListHasContextMenuOnSelection (249ms)
 ✗ #testListShowsNotLoadedProject (260ms)
 ✗ #testListShowsUpToDateProject (256ms)
 ✗ #testSortingByBranchDoesNotFail (261ms)
 ✗ #testSortingByNameDoesNotFail (258ms)
 ✗ #testSortingByStatusDoesNotFail (258ms)
 ✗ #testSortingDescendingByBranchDoesNotFail (257ms)
 ✗ #testSortingDescendingByNameDoesNotFail (259ms)
 ✗ #testSortingDescendingByStatusDoesNotFail (263ms)
 ✗ #testSortingOriginalByBranchDoesNotFail (262ms)
 ✗ #testSortingOriginalByNameDoesNotFail (266ms)
 ✗ #testSortingOriginalByStatusDoesNotFail (267ms)
 ✗ #testTableHasTheCorrectColumns (250ms)

IceMetacelloProjectSourcePropertiesTonel
 ✗ #testInstallBaselineWhenNoSSHIsAvailableUsesHTTPS (150ms)
 ✗ #testInstallBaselineWhileMissingRepositoryIsInstalledIsPossible (156ms)
 ✗ #testInstallBaselineWithConflictingRepositoryInDiskThrowsError (146ms)
 ✗ #testInstallingAMetacelloBaselineCreatesAnIcebergRepository (147ms)
 ✗ #testNewRepositoryPackagesAreClean (142ms)
 ✗ #testProjectDirtiness (164ms)
 ✗ #testProjectFileFormat (144ms)
 ✗ #testProjectHasDescriptor (142ms)
 ✗ #testInstallBaselineWhenNoSSHIsAvailableUsesHTTPS (166ms)
 ✗ #testInstallBaselineWhileMissingRepositoryIsInstalledIsPossible (463ms)
 ✗ #testInstallBaselineWithConflictingRepositoryInDiskThrowsError (455ms)
 ✗ #testInstallingAMetacelloBaselineCreatesAnIcebergRepository (462ms)
 ✗ #testNewRepositoryPackagesAreClean (448ms)
 ✗ #testProjectDirtiness (460ms)
 ✗ #testProjectFileFormat (457ms)
 ✗ #testProjectHasDescriptor (467ms)
 ✗ #testInstallBaselineWhenNoSSHIsAvailableUsesHTTPS (435ms)
 ✗ #testInstallBaselineWhileMissingRepositoryIsInstalledIsPossible (461ms)
 ✗ #testInstallBaselineWithConflictingRepositoryInDiskThrowsError (499ms)
 ✗ #testInstallingAMetacelloBaselineCreatesAnIcebergRepository (459ms)
 ✗ #testNewRepositoryPackagesAreClean (555ms)
 ✗ #testProjectDirtiness (445ms)
 ✗ #testProjectFileFormat (454ms)
 ✗ #testProjectHasDescriptor (477ms)
 ✗ #testInstallBaselineWhenNoSSHIsAvailableUsesHTTPS (437ms)
 ✗ #testInstallBaselineWhileMissingRepositoryIsInstalledIsPossible (448ms)
 ✗ #testInstallBaselineWithConflictingRepositoryInDiskThrowsError (470ms)
 ✗ #testInstallingAMetacelloBaselineCreatesAnIcebergRepository (434ms)
 ✗ #testNewRepositoryPackagesAreClean (449ms)
 ✗ #testProjectDirtiness (449ms)
 ✗ #testProjectFileFormat (436ms)
 ✗ #testProjectHasDescriptor (446ms)
 ✗ #testInstallBaselineWhenNoSSHIsAvailableUsesHTTPS (445ms)
 ✗ #testInstallBaselineWhileMissingRepositoryIsInstalledIsPossible (600ms)
 ✗ #testInstallBaselineWithConflictingRepositoryInDiskThrowsError (437ms)
 ✗ #testInstallingAMetacelloBaselineCreatesAnIcebergRepository (565ms)
 ✗ #testNewRepositoryPackagesAreClean (437ms)
 ✗ #testProjectDirtiness (434ms)
 ✗ #testProjectFileFormat (464ms)
 ✗ #testProjectHasDescriptor (458ms)

IceSinglePackageLocalGitRepositoryWithDotSubdirectoryTest
 ✗ #testAddNewRemoteListsRemote (229ms)
 ✗ #testNewRepositoryHasNoRemotes (223ms)

IceMultiplePackageLocalGitRepositoryTest
 ✗ #testAddNewRemoteListsRemote (229ms)
 ✗ #testNewRepositoryHasNoRemotes (222ms)


  Executed 2068 Tests with 1 Failures and 515 Errors in 315.04s.

@estebanlm
Copy link
Collaborator Author

yeah, because I need to first process a PR in libgit2-bindings :P

Copy link
Contributor

@jecisc jecisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should use the theme for the colors but this already improve a lot the situation :)

@estebanlm
Copy link
Collaborator Author

I check it looks good in both, that's good enough for now :P

@jecisc
Copy link
Contributor

jecisc commented Sep 14, 2023

The change seems ok, should we merge?

@estebanlm estebanlm merged commit 9911023 into dev-2.0 Sep 14, 2023
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants