Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add command menus for diffpanel in repository commit historic #1850

Open
wants to merge 3 commits into
base: Pharo13
Choose a base branch
from
Open

Add command menus for diffpanel in repository commit historic #1850

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
928ab62
Add command menus for diffpanel in repository commit historic
AlexisCnockaert Nov 8, 2024
9e27a4e
Branch: Pharo13, fixes #1852
AlexisCnockaert Nov 13, 2024
dffa74e
Branch: Pharo13, few changes
AlexisCnockaert Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Iceberg-TipUI/IceTipCommentPanel.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ IceTipCommentPanel >> initializePresenters [
enabled: false ].

commentText := self newText
placeholder: 'A comment for your commit';
text: 'Branch: ', repositoryModel branchName, ', Fix #'
yourself.

fixesHelpString := 'Enter the number of the issue that you fixed. Github will close it when it will be committed or merged in the default branch'.
Expand Down
23 changes: 21 additions & 2 deletions Iceberg-TipUI/IceTipDiffPanel.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,8 @@ also #elements answer should be a collection of elements that also understand el
"
Class {
#name : 'IceTipDiffPanel',
#superclass : 'IceTipPresenter',
#superclass : 'IceTipBrowser',
#instVars : [
'model',
'diffPanel',
'iceNodesTree'
],
Expand All @@ -19,6 +18,20 @@ Class {
#tag : 'View-Branch'
}

{ #category : 'commands' }
IceTipDiffPanel class >> buildGeneralCommandGroupWith: presenter for: aCommandGroup [

"Nothing to add"
]

{ #category : 'commands' }
IceTipDiffPanel class >> buildSelectionCommandGroupWith: presenter for: aCommandGroup [
{
IceTipBrowseCommand.
IceTipInspectCommand } do: [ :each |
aCommandGroup register: (each forSpecContext: presenter)]
]

{ #category : 'instance creation' }
IceTipDiffPanel class >> onDiff: aDiff [

Expand Down Expand Up @@ -204,6 +217,12 @@ IceTipDiffPanel >> leftLabel: aString [
diffPanel leftLabel: aString.
]

{ #category : 'accessing - ui' }
IceTipDiffPanel >> mainList [

^iceNodesTree
]

{ #category : 'accessing' }
IceTipDiffPanel >> model [

Expand Down