Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EditorGuidelines Extension Breaks the Built-In Visual Studio Spell Checker #116

Closed
EWSoftware opened this issue Apr 23, 2023 · 8 comments · Fixed by #117
Closed

EditorGuidelines Extension Breaks the Built-In Visual Studio Spell Checker #116

EWSoftware opened this issue Apr 23, 2023 · 8 comments · Fixed by #117
Labels

Comments

@EWSoftware
Copy link

EWSoftware commented Apr 23, 2023

There seems to be a conflict between the latest Visual Studio 2022 (17.5.4) and the EditorGuidelines extension. The extension is somehow breaking the built in Visual Studio spell checker such that it never completes and offers suggestions for misspelled words. I also notice that this in turn can also block other code fixes as well such that they never show suggestions.

I'm the creator of the Visual Studio spell checker extension and noticed an issue in mine with the smart tags not popping up automatically anymore when you hovered the mouse over a misspelling. Using the shortcut key to show the suggestions worked but there was always a "Loading suggestions" item at the bottom with a continuous progress bar.

Thinking the issue was in my extension I removed it and still saw similar issues with other standard code fixes not offering suggestions. As such, I started disabling other extensions to try and track down the cause. After disabling the EditorGuidelines extensions, everything started working again and I noticed that the built in Visual Studio spell checker was enabled and offering suggestions. I hadn't noticed it was enabled before due to it being blocked and perhaps not enabled until this latest Visual Studio update.

After enabling the EditorGuidelines extension, the built-in spell checker suggestions went away again. However, if I press the shortcut key to show suggestions on a misspelled word, the popup appears with the same "Loading suggestions" message and progress bar as shown below and it never completes.

image

With the guidelines extension disabled, the popups work as expected in my own extension as well. As noted, I hadn't noticed this behavior prior to the 17.5.4 update. Also, disabling the built in Visual Studio spell checker fixes the issues as well so the conflict does appear to be with it specifically.

@pharring pharring added the bug label Apr 24, 2023
@pharring
Copy link
Owner

Thanks for the report. I will investigate and try to reproduce it.

@pharring
Copy link
Owner

Reproduced. Debugging.

@pharring
Copy link
Owner

The problem is with Microsoft.VisualStudio.CodingConventions
This is the assembly we use to read .editorconfig files.
The version included with EditorGuidelines (1.1.20180503.2) is incompatible with the one that ships in 17.5.4
It looks like that assembly has been de-listed from nuget.org. I need to find a replacement.

@pharring
Copy link
Owner

I think I have a fix.
We use the de-listed assembly at build time, but don't include the assembly in the VSIX. Instead, it'll be picked up from PublicAssemblies. I'm assuming that the CodingConventions assembly is available in all SKUs and all workloads.

@pharring
Copy link
Owner

I think it's fixed. I will try to get a new release published tomorrow.

@pharring
Copy link
Owner

The fix has been published in version 2.2.10 to the VS Marketplace.

@EWSoftware
Copy link
Author

It's working as expected now. Thanks for the quick fix.

@prlcutting
Copy link

As a user of both the Editor Guidelines and Spell Checker extensions, I noticed the same behavior recently, but had no idea what the cause was. Thank you for the rapid fix.

And thank you both for the fantastic extensions that you maintain for the community. It is much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants