Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port icons from Power Tools extension #49

Closed
pharring opened this issue Jun 13, 2019 · 6 comments · Fixed by #52
Closed

Port icons from Power Tools extension #49

pharring opened this issue Jun 13, 2019 · 6 comments · Fixed by #52

Comments

@pharring
Copy link
Owner

According to a review on the Marketplace, the Power Tools extension had

up-to-date VS2017-style icons (this extension still uses old-school colored ones which look bad on a dark theme).

I believe this is referring to the icons on the context menu commands.
See if we can locate the icons used in Power Tools and port them over.
(May need to seek permission from the current Power Tools owners or find alternatives)

@RayKoopa
Copy link

Hey there, thanks for tracking this.

Yeah, I indeed meant the context menu icons with this. This is how they look with a dark theme in the Power Tools version in 2017 and this extension:
image
image

I updated my review on the gallery according to your reply. Speaking of the context menu, I also wondered if an entry to change the guideline color (as in the Power Tools version) should be added to make that feature more discoverable.

@pharring
Copy link
Owner Author

I located the icons from PPT. Need to check with the current owners if I have permission to use them.

@pharring
Copy link
Owner Author

See #50 for bringing back "Guideline Color..."

@pharring
Copy link
Owner Author

Got permission to use the icons. I should have time to push out an update this weekend.

@RayKoopa
Copy link

Excellent! I'll update my review when it's out.

pharring added a commit that referenced this issue Jun 15, 2019
pharring added a commit that referenced this issue Jun 15, 2019
* Update command bar icons from PPT
Fix #49

* Update changelog

* Update to version 2.2.4

* Update context menu screenshot with new icons
@pharring
Copy link
Owner Author

Release 2.2.4 with the updated icons is in the Marketplace now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants