resolve zero port on all interfaces, not just localhost; GetPort rena… #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
Thanks for the useful library / tool.
The main reasons for this pull request are:
l.Close()
withl.Close()
- I want to shutdown the listener as fast as possible to avoid "bind: address already in use"GetPort
was market as deprecated for 1 year, so I thought it wouldn't be much harm to rename it intoMustGetFreePort
according to the go naming convention. It's nice to have such function for usage in tests.