refactor: added 21 as default min_sdk_android

phellowseven · Aug 1, 2022 · f58fdce · f58fdce
1 parent 0f3ad18
commit f58fdce
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/README.md b/README.md
@@ -21,7 +21,7 @@ flutter_icons:
   android: "launcher_icon"
   ios: true
   image_path: "assets/icon/icon.png"
-  min_sdk_android: 21 # android min sdk min:16
+  min_sdk_android: 21 # android min sdk min:16, default 21
   web:
     generate: true
     image_path: "path/to/image.png"

diff --git a/lib/android.dart b/lib/android.dart
@@ -272,7 +272,7 @@ List<String> _transformAndroidManifestWithNewLauncherIcon(List<String> oldManife
 /// - local.properties: `'android/local.properties'`
 ///
 /// If found none returns 0
-int? minSdk() {
+int minSdk() {
   final androidGradleFile = File(constants.androidGradleFile);
   final androidLocalPropertiesFile = File(constants.androidLocalPropertiesFile);
 
@@ -281,7 +281,8 @@ int? minSdk() {
   // first check build.gradle, then local.properties, then flutter.gradle
   return _getMinSdkFromFile(androidGradleFile) ??
       _getMinSdkFromFile(androidLocalPropertiesFile) ??
-      _getMinSdkFlutterGradle(androidLocalPropertiesFile);
+      _getMinSdkFlutterGradle(androidLocalPropertiesFile) ??
+      constants.androidDefaultAndroidMinSDK;
 }
 
 /// Retrieves the minSdk value from [File]

diff --git a/lib/main.dart b/lib/main.dart
@@ -125,7 +125,7 @@ Future<void> createIconsFromConfig(
   }
 
   if (isNeedingNewAndroidIcon(config) || hasAndroidAdaptiveConfig(config)) {
-    final int minSdk = config['min_sdk_android'] ?? android_launcher_icons.minSdk() ?? 0;
+    final int minSdk = config['min_sdk_android'] ?? android_launcher_icons.minSdk();
     if (minSdk == 0) {
       throw const InvalidConfigException(errorMissingMinSdk);
     }