Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for "hello world" not getting displayed #1252

Closed
wants to merge 2 commits into from
Closed

Fix for "hello world" not getting displayed #1252

wants to merge 2 commits into from

Conversation

rprovodenko
Copy link

@rprovodenko rprovodenko commented Nov 19, 2023 •
edited
Loading

Explanation: #1249 (comment)

Rostislav Provodenko added 2 commits November 19, 2023 20:56
@rprovodenko rprovodenko mentioned this pull request Nov 19, 2023
Closed
AtomicGamer9523
AtomicGamer9523 suggested changes Nov 20, 2023
View reviewed changes
Copy link

@AtomicGamer9523 AtomicGamer9523 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sorry, but the original did everything correctly:
orginal
Running your version resulted in this:
updated
Info:

Fresh Installation of Qemu:
    QEMU Guest Agent 8.1.0 (v8.1.0-12034-g129566d84e)
Rustc:
    rustc 1.76.0-nightly (4cb3beec8 2023-11-18)
    binary: rustc
    commit-hash: 4cb3beec86178baff601529389306a4949b077ce
    commit-date: 2023-11-18
    host: x86_64-pc-windows-msvc
    release: 1.76.0-nightly
    LLVM version: 17.0.5

@phil-opp
Copy link
Owner

Thanks for openinig this PR! However, it seems like the issue is a bug in QEMU on macOS that doesn't show the first line properly. Apparently, the line is just hidden by the title bar and visible once you go to fullscreen mode. So the code seems to be correct, it's just a QEMU display issue.

@phil-opp phil-opp closed this Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AtomicGamer9523 AtomicGamer9523 AtomicGamer9523 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rprovodenko @phil-opp @AtomicGamer9523