Execute "javascript:" URLs by injecting them into the page itself. #3211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `chrome.tabs.update()` no longer supports `javascript:` URLs, here we inject them into the page itself. Replaces philc#3167. Replaces philc#3209. Fixes philc#3178.
|
I also really miss being able to run bookmarklets from the vomnibar. Any chance this PR can get reviewed @gdh1995 @smblott-github ? |
gdh1995
suggested changes
Nov 11, 2019
| injectUserScript: (text) -> | ||
| text = text[11..] if text[...11] == "javascript:" | ||
| script = document.createElement "script" | ||
| script.textContent = text |
There was a problem hiding this comment.
um, 'try/catch decodeURIComponment(url)' is needed.
There was a problem hiding this comment.
I've added #3437 to add such a try decodeURI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OK, @gdh1995... like this?
Since
chrome.tabs.update()no longer supportsjavascript:URLs, here we inject them into the page itself.Replaces #3167.
Replaces #3209.
Fixes #3178.