Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.3.2: Fix --accept #44

Merged
merged 6 commits into from
Jul 19, 2024
Merged

v3.3.2: Fix --accept #44

merged 6 commits into from
Jul 19, 2024

Conversation

andreasabel
Copy link
Collaborator

@andreasabel andreasabel commented Jul 18, 2024

Commits:

  • [refactor] remove determined argument of local function printResultLine
  • [refactor] local function possiblyAccept instead of cut&paste code
  • Fix --accept by unifing interactive and non-interactive test runs
  • Bump CI to GHC 9.10.1
  • Bump version to 3.3.2 and CHANGELOG

Closes #24.

@andreasabel andreasabel changed the title accept v3.3.2: Fix --accept Jul 18, 2024
@andreasabel andreasabel added this to the 3.3.2 milestone Jul 18, 2024
@andreasabel
Copy link
Collaborator Author

@phile314 @german1608 @aronerben Could you test this PR before I release?

@andreasabel
Copy link
Collaborator Author

andreasabel commented Jul 19, 2024

Ah, I just publish it. There seem hardly any users of tasty-silver, at least neither Stackage nor Hackage list any dependents.

Candidate release: https://hackage.haskell.org/package/tasty-silver-3.3.2/candidate

@andreasabel andreasabel merged commit 1b85eb7 into master Jul 19, 2024
15 checks passed
@aronerben
Copy link

@andreasabel Thank you very much for the fix and the release, I will test it at a later time.

@andreasabel andreasabel deleted the accept branch July 22, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--accept with Test.Tasty.Silver.Interactive.defaultMain doesn't update/create golden files
2 participants